Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PriorityAssigner does not revert priority updates if flow priority updates failed to be realized on OVS #1095

Closed
Dyanngg opened this issue Aug 14, 2020 · 0 comments · Fixed by #1096
Closed

PriorityAssigner does not revert priority updates if flow priority updates failed to be realized on OVS #1095

Dyanngg opened this issue Aug 14, 2020 · 0 comments · Fixed by #1096
Assignees
@Dyanngg
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Dyanngg
Copy link
Contributor

Dyanngg commented Aug 14, 2020

Describe the bug
priorityAssigner will issue priority updates to reconciler if a newly inserted priority requires established OVS flows to alter their priorities. If such operation fails, priorityAssigner should revert its internal mappings of priority<->ofPriority. Otherwise, the state in priorityAssigner and OVS table will be different.

To Reproduce
Currently not reproducible there is no known sequence of actions that will cause flow priority re-assignment to fail.

Expected behavior
priorityAssigner rolls back priority updates should the flow priority update installation fail for some reason.
@Dyanngg Dyanngg added the kind/bug Categorizes issue or PR as related to a bug. label Aug 14, 2020
@Dyanngg Dyanngg self-assigned this Aug 14, 2020
@Dyanngg Dyanngg mentioned this issue Aug 15, 2020
Merged
antoninbas pushed a commit that referenced this issue Aug 20, 2020
@Dyanngg
Revert priority updates if flow realization fails (#1096)
830c71c 
* Revert priority updates if flow realization fails

* Return the revert function as closure in the re-assignment process

* Address comments

Fixes #1095
antoninbas pushed a commit to antoninbas/antrea that referenced this issue Aug 21, 2020
@Dyanngg @antoninbas
Revert priority updates if flow realization fails (antrea-io#1096)
6ffd5af 
* Revert priority updates if flow realization fails

* Return the revert function as closure in the re-assignment process

* Address comments

Fixes antrea-io#1095
antoninbas pushed a commit that referenced this issue Aug 21, 2020
@Dyanngg @antoninbas
Revert priority updates if flow realization fails (#1096)
56feb00 
* Revert priority updates if flow realization fails

* Return the revert function as closure in the re-assignment process

* Address comments

Fixes #1095
GraysonWu pushed a commit to GraysonWu/antrea that referenced this issue Sep 22, 2020
@Dyanngg @GraysonWu
Revert priority updates if flow realization fails (antrea-io#1096)
d4f3434 
* Revert priority updates if flow realization fails

* Return the revert function as closure in the re-assignment process

* Address comments

Fixes antrea-io#1095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dyanngg Dyanngg

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert priority updates if flow realization fails Dyanngg/antrea
1 participant
@Dyanngg