Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: endpoint dnat flows should resubmit packets to cnp egress table #1119

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Bug fix: endpoint dnat flows should resubmit packets to cnp egress table #1119

merged 1 commit into from
Aug 21, 2020

Conversation

weiqiangt
Copy link
Contributor

Endpoint dnat flows should resubmit packets to the first cnp egress
table instead of the EgressRuleTable, otherwise cnp will not take effect
on service traffic.

Signed-off-by: Weiqiang Tang weiqiangt@vmware.com

@weiqiangt
Bug fix: endpoint dnat flows should resubmit packets to cnp egress table
df6653d 
Endpoint dnat flows should resubmit packets to the first cnp egress
table instead of the EgressRuleTable, otherwise cnp will not take effect
on service traffic.

Signed-off-by: Weiqiang Tang <weiqiangt@vmware.com>
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@weiqiangt weiqiangt requested review from yktsubo and Dyanngg August 20, 2020 06:48
@weiqiangt
Copy link
Contributor Author

/test-all

Dyanngg
Dyanngg approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

yktsubo
yktsubo approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@yktsubo yktsubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yktsubo
Copy link
Contributor

yktsubo commented Aug 20, 2020

Maybe we should add a test case for the scenario where both antrea proxy and CNP are enabled

@weiqiangt weiqiangt mentioned this pull request Aug 21, 2020
Closed
@weiqiangt weiqiangt merged commit 36e674f into antrea-io:master Aug 21, 2020
@weiqiangt weiqiangt deleted the bugfix-ap-endpointdnat-resubmit branch August 21, 2020 11:48
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Aug 21, 2020
@weiqiangt @antoninbas
Bug fix: endpoint dnat flows should resubmit packets to cnp egress ta…
c9ff460 
…ble (antrea-io#1119)

Endpoint dnat flows should resubmit packets to the first cnp egress
table instead of the EgressRuleTable, otherwise cnp will not take effect
on service traffic.

Signed-off-by: Weiqiang Tang <weiqiangt@vmware.com>
antoninbas pushed a commit that referenced this pull request Aug 21, 2020
@weiqiangt @antoninbas
Bug fix: endpoint dnat flows should resubmit packets to cnp egress ta…
eb4bbc3 
…ble (#1119)

Endpoint dnat flows should resubmit packets to the first cnp egress
table instead of the EgressRuleTable, otherwise cnp will not take effect
on service traffic.

Signed-off-by: Weiqiang Tang <weiqiangt@vmware.com>
tnqn pushed a commit to tnqn/antrea that referenced this pull request Aug 27, 2020
@weiqiangt @tnqn
Bug fix: endpoint dnat flows should resubmit packets to cnp egress ta…
0105a79 
…ble (antrea-io#1119)

Endpoint dnat flows should resubmit packets to the first cnp egress
table instead of the EgressRuleTable, otherwise cnp will not take effect
on service traffic.

Signed-off-by: Weiqiang Tang <weiqiangt@vmware.com>
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@weiqiangt @GraysonWu
Bug fix: endpoint dnat flows should resubmit packets to cnp egress ta…
a0310af 
…ble (antrea-io#1119)

Endpoint dnat flows should resubmit packets to the first cnp egress
table instead of the EgressRuleTable, otherwise cnp will not take effect
on service traffic.

Signed-off-by: Weiqiang Tang <weiqiangt@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns approved these changes

@yktsubo yktsubo yktsubo approved these changes

@Dyanngg Dyanngg Dyanngg approved these changes

@tnqn tnqn tnqn approved these changes

@antoninbas antoninbas Awaiting requested review from antoninbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@weiqiangt @antrea-bot @yktsubo @tnqn @Dyanngg @jianjuns @vmwclabot