Fix race condition in GetCurrentNS temporarily #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
|
|
/test-all |
|
@antoninbas This should fix the issue too without replacing the module in go.mod, please let me know if it makes sense to you. |
In GetCurrentNS, If there is a context-switch between getCurrentThreadNetNSPath and GetNS, another goroutine may execute in the original thread and change its network namespace, then the original goroutine would get the updated network namespace, which could lead to unexpected behavior, especially when GetCurrentNS is used to get the host network namespace in netNS.Do. Instead of using the provided netns argument, this patch fixes it by getting the hostNS in advance with the OS thread locked.
|
/test-all |
2 tasks
|
/test-windows-networkpolicy |
jianjuns
reviewed
Aug 21, 2020
| if err := ns.WithNetNSPath(containerNetNS, func(hostNS ns.NetNS) error { | ||
|
|
||
| // This is a workaround for issue #1113, which is caused by https://github.com/containernetworking/plugins/issues/524. | ||
| // Instead of using the provided netns argument, which might not be the real hostNS, it fixes it by getting the |
There was a problem hiding this comment.
it fixes by getting -> this fix gets
There was a problem hiding this comment.
@jianjuns I think "it fixes it" is correct here, even though I like your suggestion better. However, since this is your only comment and Quan may have started his weekend, I will merge this and proceed with the 0.9.1 release.
jianjuns
reviewed
Aug 21, 2020
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Aug 21, 2020
In GetCurrentNS, If there is a context-switch between getCurrentThreadNetNSPath and GetNS, another goroutine may execute in the original thread and change its network namespace, then the original goroutine would get the updated network namespace, which could lead to unexpected behavior, especially when GetCurrentNS is used to get the host network namespace in netNS.Do. Instead of using the provided netns argument, this patch fixes it by getting the hostNS in advance with the OS thread locked.
antoninbas
pushed a commit
that referenced
this pull request
Aug 21, 2020
In GetCurrentNS, If there is a context-switch between getCurrentThreadNetNSPath and GetNS, another goroutine may execute in the original thread and change its network namespace, then the original goroutine would get the updated network namespace, which could lead to unexpected behavior, especially when GetCurrentNS is used to get the host network namespace in netNS.Do. Instead of using the provided netns argument, this patch fixes it by getting the hostNS in advance with the OS thread locked.
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Aug 27, 2020
In GetCurrentNS, If there is a context-switch between getCurrentThreadNetNSPath and GetNS, another goroutine may execute in the original thread and change its network namespace, then the original goroutine would get the updated network namespace, which could lead to unexpected behavior, especially when GetCurrentNS is used to get the host network namespace in netNS.Do. Instead of using the provided netns argument, this patch fixes it by getting the hostNS in advance with the OS thread locked.
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 22, 2020
In GetCurrentNS, If there is a context-switch between getCurrentThreadNetNSPath and GetNS, another goroutine may execute in the original thread and change its network namespace, then the original goroutine would get the updated network namespace, which could lead to unexpected behavior, especially when GetCurrentNS is used to get the host network namespace in netNS.Do. Instead of using the provided netns argument, this patch fixes it by getting the hostNS in advance with the OS thread locked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GetCurrentNS, If there is a context-switch between
getCurrentThreadNetNSPath and GetNS, another goroutine may execute in
the original thread and change its network namespace, then the original
goroutine would get the updated network namespace, which could lead to
unexpected behavior, especially when GetCurrentNS is used to get the
host network namespace in netNS.Do.
Instead of using the provided netns argument, this patch fixes it by
getting the hostNS in advance with the OS thread locked.
Fixes #1113