-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ipv6 in antctl #1995
support ipv6 in antctl #1995
Conversation
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #1995 +/- ##
===========================================
- Coverage 65.39% 53.13% -12.26%
===========================================
Files 197 197
Lines 17217 17302 +85
===========================================
- Hits 11259 9194 -2065
- Misses 4785 7214 +2429
+ Partials 1173 894 -279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test-networkpolicy |
Is it possible to have some antctl traceflow e2e cases? |
I think @luolanzone can investigate this but we may not have enough time to add and verify this before deadline. |
Sure, we can skip it for now if urgent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the change, but can be better if we can automatically use IPv6 is the source Pod has only IPv6 address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mengdie-song Any comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
contribute to #1988