Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ipv6 in antctl #1995

Merged
merged 2 commits into from
Mar 31, 2021
Merged

support ipv6 in antctl #1995

merged 2 commits into from
Mar 31, 2021

Conversation

luolanzone
Copy link
Contributor

contribute to #1988

docs/antctl.md Outdated Show resolved Hide resolved
@gran-vmv
Copy link
Contributor

/test-all

@codecov-io
Copy link

codecov-io commented Mar 26, 2021

Codecov Report

Merging #1995 (6228956) into main (9b8440d) will decrease coverage by 12.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1995       +/-   ##
===========================================
- Coverage   65.39%   53.13%   -12.26%     
===========================================
  Files         197      197               
  Lines       17217    17302       +85     
===========================================
- Hits        11259     9194     -2065     
- Misses       4785     7214     +2429     
+ Partials     1173      894      -279     
Flag Coverage Δ
e2e-tests 26.27% <ø> (?)
kind-e2e-tests ?
unit-tests 41.74% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/antctl/raw/traceflow/command.go 27.05% <100.00%> (+2.55%) ⬆️
pkg/apis/controlplane/helper.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/controller/types/networkpolicy.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/nodeportlocal/rules/rules.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/apis/controlplane/v1beta2/helper.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 0.00% <0.00%> (-83.88%) ⬇️
pkg/ipfix/ipfix_process.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/ipfix/ipfix_set.go 20.00% <0.00%> (-80.00%) ⬇️
pkg/ipfix/ipfix_intermediate.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/ipfix/ipfix_collector.go 0.00% <0.00%> (-77.78%) ⬇️
... and 97 more

@gran-vmv
Copy link
Contributor

/test-networkpolicy

@lzhecheng
Copy link
Contributor

Is it possible to have some antctl traceflow e2e cases?

@gran-vmv gran-vmv added this to the Antrea v1.0 release milestone Mar 29, 2021
@gran-vmv
Copy link
Contributor

Is it possible to have some antctl traceflow e2e cases?

I think @luolanzone can investigate this but we may not have enough time to add and verify this before deadline.

@lzhecheng
Copy link
Contributor

Is it possible to have some antctl traceflow e2e cases?

I think @luolanzone can investigate this but we may not have enough time to add and verify this before deadline.

Sure, we can skip it for now if urgent.

Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the change, but can be better if we can automatically use IPv6 is the source Pod has only IPv6 address.

Copy link
Contributor

@gran-vmv gran-vmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gran-vmv
Copy link
Contributor

@mengdie-song Any comments?

Copy link
Contributor

@mengdie-song mengdie-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gran-vmv gran-vmv merged commit fbbda2b into antrea-io:main Mar 31, 2021
@luolanzone luolanzone deleted the antctl-ipv6 branch April 14, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants