Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Add Antrea Windows design doc #751

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[Windows] Add Antrea Windows design doc #751

merged 1 commit into from
Jun 4, 2020

Conversation

wenyingd
Copy link
Contributor

Signed-off-by: Rui Cao rcao@vmware.com
Signed-off-by: wenyingd wenyingd@vmware.com

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@wenyingd wenyingd force-pushed the windows_design branch 3 times, most recently from 78079c4 to 6664a6a Compare May 28, 2020 13:10
@ruicao93 ruicao93 requested review from antoninbas and jianjuns May 29, 2020 00:13
@wenyingd wenyingd requested review from tnqn and ruicao93 May 29, 2020 01:05
@wenyingd
Copy link
Contributor Author

/skip-all

antoninbas
antoninbas reviewed May 29, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of suggestions

docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
@wenyingd wenyingd force-pushed the windows_design branch 2 times, most recently from f36323f to dd91fd4 Compare May 29, 2020 04:09
antoninbas
antoninbas reviewed May 29, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of suggestions

docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
antoninbas
antoninbas reviewed May 29, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of comments

I will do another review later as I may have missed some things, or some of my comments may have been lost as edits were being made simultaneously.

docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
This was referenced May 29, 2020
Merged
Merged
jianjuns
jianjuns reviewed May 29, 2020
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my old comments in #706.

docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
@wenyingd wenyingd mentioned this pull request May 29, 2020
Merged
@wenyingd
Copy link
Contributor Author

wenyingd commented Jun 1, 2020

/skip-all

jianjuns
jianjuns previously approved these changes Jun 2, 2020
View reviewed changes
antoninbas
antoninbas reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my earlier comments, I know there were a lot of them.

I did a second review and found a few more issues. Thanks for bearing with me, I think this is a high-quality document and it will be very useful for potential new contributors.

docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
docs/windows-design.md Outdated Show resolved Hide resolved
@ruicao93 @wenyingd
[Windows] Add Antrea Windows design doc
490fb17 
Signed-off-by: Rui Cao <rcao@vmware.com>
Signed-off-by: wenyingd <wenyingd@vmware.com>
@wenyingd
Copy link
Contributor Author

wenyingd commented Jun 3, 2020

/skip-all

antoninbas
antoninbas approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the work you put into this document!

@wenyingd wenyingd merged commit dd638ee into antrea-io:master Jun 4, 2020
@wenyingd wenyingd mentioned this pull request Jun 23, 2020
Closed
21 tasks
@wenyingd wenyingd deleted the windows_design branch August 18, 2020 01:42
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@wenyingd @antoninbas @GraysonWu
[Windows] Add Antrea Windows design doc (antrea-io#751)
98d83c7 
Signed-off-by: Rui Cao <rcao@vmware.com>
Signed-off-by: wenyingd <wenyingd@vmware.com>
Co-authored-by: Antonin Bas <antonin.bas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

@jianjuns jianjuns jianjuns left review comments

@tnqn tnqn Awaiting requested review from tnqn

@ruicao93 ruicao93 Awaiting requested review from ruicao93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wenyingd @antrea-bot @antoninbas @jianjuns @vmwclabot @ruicao93