Fix IP not released after restarting antrea-agent #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
|
/test-all |
There was no sync-up between the IPAM cache of antrea-agent and the IPAM plugin, the IPAM DEL could be skipped incorrectly when deleting a Pod created before antrea-agent was restarted, leading to IP address leak. The handling of multiple CNI DELs is idempotent. There is no need to check in-memory cache before calling IPAM DEL. This patches fixes the issue by removing the cache check and adds a verification in e2e test.
|
/test-all |
|
/test-e2e |
antoninbas
approved these changes
Jun 11, 2020
|
wanted to track issues and fixes separately, will rebase #827 on this after merging it. |
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Jun 15, 2020
There was no sync-up between the IPAM cache of antrea-agent and the IPAM plugin, the IPAM DEL could be skipped incorrectly when deleting a Pod created before antrea-agent was restarted, leading to IP address leak. The handling of multiple CNI DELs is idempotent. There is no need to check in-memory cache before calling IPAM DEL. This patches fixes the issue by removing the cache check and adds a verification in e2e test.
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Jun 16, 2020
There was no sync-up between the IPAM cache of antrea-agent and the IPAM plugin, the IPAM DEL could be skipped incorrectly when deleting a Pod created before antrea-agent was restarted, leading to IP address leak. The handling of multiple CNI DELs is idempotent. There is no need to check in-memory cache before calling IPAM DEL. This patches fixes the issue by removing the cache check and adds a verification in e2e test.
antoninbas
pushed a commit
that referenced
this pull request
Jun 16, 2020
There was no sync-up between the IPAM cache of antrea-agent and the IPAM plugin, the IPAM DEL could be skipped incorrectly when deleting a Pod created before antrea-agent was restarted, leading to IP address leak. The handling of multiple CNI DELs is idempotent. There is no need to check in-memory cache before calling IPAM DEL. This patches fixes the issue by removing the cache check and adds a verification in e2e test.
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 22, 2020
There was no sync-up between the IPAM cache of antrea-agent and the IPAM plugin, the IPAM DEL could be skipped incorrectly when deleting a Pod created before antrea-agent was restarted, leading to IP address leak. The handling of multiple CNI DELs is idempotent. There is no need to check in-memory cache before calling IPAM DEL. This patches fixes the issue by removing the cache check and adds a verification in e2e test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no sync-up between the IPAM cache of antrea-agent and the IPAM
plugin, the IPAM DEL could be skipped incorrectly when deleting a Pod
created before antrea-agent was restarted, leading to IP address leak.
The handling of multiple CNI DELs is idempotent. There is no need to
check in-memory cache before calling IPAM DEL.
This patches fixes the issue by removing the cache check and adds a
verification in e2e test.
Fixes #829