Update go-iptables library version #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
antoninbas
force-pushed
the
update-go-iptables-version
branch
from
6adad5c to
54da8ee
Compare
From 0.4.1 to 0.4.5. In version 0.4.1, no error is returned by go-iptables when running `iptables --version` or parsing its ouput fails (during initialization). This leads to the library not being able to correctly detect whether the iptables version supports `--wait`, which ultimately can lead to a deadlock for the Antrea agent. See coreos/go-iptables#69. By updating the go-iptables version, we ensure that any such error will be returned to Antrea, logged, and cause the Antrea agent to fail and eventually restart. It is unclear what can cause iptables version detection to fail but because of the added logging, we will have a better shot at getting to the root cause if it happens in production again. Fixes antrea-io#871
antoninbas
force-pushed
the
update-go-iptables-version
branch
from
54da8ee to
0719375
Compare
jianjuns
approved these changes
Jun 26, 2020
|
/test-all |
|
But can it fix/close #871 which seems not caused by iptables failure? |
|
/test-conformance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 0.4.1 to 0.4.5.
In version 0.4.1, no error is returned by go-iptables when running
iptables --versionor parsing its ouput fails (duringinitialization). This leads to the library not being able to correctly
detect whether the iptables version supports
--wait, which ultimatelycan lead to a deadlock for the Antrea agent.
See coreos/go-iptables#69.
By updating the go-iptables version, we ensure that any such error will
be returned to Antrea, logged, and cause the Antrea agent to fail and
eventually restart.
It is unclear what can cause iptables version detection to fail but
because of the added logging, we will have a better shot at getting to
the root cause if it happens in production again.
Fixes #871