Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ofPorts from lastRealized.podOFPorts after deleting an OF rule #929

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Remove ofPorts from lastRealized.podOFPorts after deleting an OF rule #929

merged 1 commit into from
Jul 9, 2020

Conversation

jianjuns
Copy link
Contributor

@jianjuns jianjuns commented Jul 9, 2020

No description provided.

@jianjuns jianjuns requested a review from tnqn July 9, 2020 00:30
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@antoninbas
Copy link
Contributor

@jianjuns out-of-curiosity, was this causing any user-facing issue beyond leaking memory?

@jianjuns
Copy link
Contributor Author

jianjuns commented Jul 9, 2020

@jianjuns out-of-curiosity, was this causing any user-facing issue beyond leaking memory?

Nothing. I just found it when making other changes.

tnqn
tnqn approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing it.

@tnqn
Copy link
Member

tnqn commented Jul 9, 2020

/test-all

@jianjuns jianjuns merged commit 5cdf488 into antrea-io:master Jul 9, 2020
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Jul 9, 2020
@jianjuns @antoninbas
Remove ofPorts from lastRealized.podOFPorts after deleting an OF rule (…
675b777 
…antrea-io#929)
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Jul 14, 2020
@jianjuns @antoninbas
Remove ofPorts from lastRealized.podOFPorts after deleting an OF rule (…
0b2fa0d 
…antrea-io#929)
antoninbas pushed a commit that referenced this pull request Jul 14, 2020
@jianjuns @antoninbas
Remove ofPorts from lastRealized.podOFPorts after deleting an OF rule (…
d1b8545 
…#929)
@jianjuns jianjuns deleted the np-reconcile branch August 25, 2020 21:54
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@jianjuns @GraysonWu
Remove ofPorts from lastRealized.podOFPorts after deleting an OF rule (…
a7ec64b 
…antrea-io#929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jianjuns @antrea-bot @antoninbas @tnqn @vmwclabot