Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finding destination MAC by IP in traceflow #981

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Add finding destination MAC by IP in traceflow #981

merged 1 commit into from
Jul 30, 2020

Conversation

ZhangYW18
Copy link
Contributor

Find the destination MAC in traceflow controller by destination IP via local cache.

Solved a TODO in traceflow. Testing accepted on local machine.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@gran-vmv gran-vmv added this to the Antrea v0.9.0 release milestone Jul 27, 2020
@ZhangYW18 ZhangYW18 closed this Jul 27, 2020
@ZhangYW18 ZhangYW18 reopened this Jul 27, 2020
@gran-vmv
Copy link
Contributor

/test-all

gran-vmv
gran-vmv approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@gran-vmv gran-vmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gran-vmv gran-vmv mentioned this pull request Jul 28, 2020
Merged
@antrea-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@gran-vmv gran-vmv merged commit be28dd1 into antrea-io:master Jul 30, 2020
antoninbas added a commit to antoninbas/antrea that referenced this pull request Jul 30, 2020
@antoninbas
Fix intraNodeUDPDstIPTraceflow Traceflow e2e test
0e30588 
The test was incorrect (traffic is dropped by an ingress policy
rule). However, this only became apparent after antrea-io#981 was merged and the
DMAC of the Traceflow packet started being set correctly.
@antoninbas antoninbas mentioned this pull request Jul 30, 2020
Merged
antoninbas added a commit that referenced this pull request Jul 31, 2020
@antoninbas
Fix intraNodeUDPDstIPTraceflow Traceflow e2e test
43dcdf9 
The test was incorrect (traffic is dropped by an ingress policy
rule). However, this only became apparent after #981 was merged and the
DMAC of the Traceflow packet started being set correctly.
@ZhangYW18 ZhangYW18 deleted the tf-mac branch July 31, 2020 01:46
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@ZhangYW18 @GraysonWu
Find destination MAC by IP in traceflow (antrea-io#981)
6d1b86f
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@antoninbas @GraysonWu
Fix intraNodeUDPDstIPTraceflow Traceflow e2e test
004f943 
The test was incorrect (traffic is dropped by an ingress policy
rule). However, this only became apparent after antrea-io#981 was merged and the
DMAC of the Traceflow packet started being set correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gran-vmv gran-vmv gran-vmv approved these changes

@jianjuns jianjuns jianjuns approved these changes

@wenyingd wenyingd Awaiting requested review from wenyingd

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

@tnqn tnqn Awaiting requested review from tnqn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v0.9.0 release
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhangYW18 @antrea-bot @gran-vmv @jianjuns