Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kctrl package installed update creates a package install with empty package name #682

Closed
praveenrewar opened this issue May 11, 2022 · 0 comments · Fixed by #692
Closed
Assignees
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli priority/important-soon Must be staffed and worked on currently or soon.

Comments

@praveenrewar
Copy link
Member

What steps did you take:

$ kctrl package installed update -i test-carvel-pkg --version 3.0.0-rc.1 -n test-ns --install
Getting package install for 'test-carvel-pkg'
Updating package install for 'test-carvel-pkg'
Waiting for PackageInstall reconciliation for 'test-carvel-pkg'
3:46:46PM: packageinstall/test-carvel-pkg (packaging.carvel.dev/v1alpha1) namespace: test-ns: ReconcileFailed
Error: packageinstall/test-carvel-pkg (packaging.carvel.dev/v1alpha1) namespace: test-ns: Reconciling: . Reconcile failed: Expected to find at least one version, but did not (details: a...
$ kctrl package installed update -i test-carvel-pkg -p pkg.test.carvel.dev  --version 3.0.0-rc.1 -n test-ns --install
Getting package install for 'test-carvel-pkg'
Error: Installed package 'test-carvel-pkg' is already associated with package ''

What happened:
kctrl created a package install with empty package name when using --install flag with package installed update command and not providing a package name.

What did you expect:
Error saying package name is required.

Anything else you would like to add:
[Additional information that will assist in solving the issue.]
This should be resolved with #678, but creating an issue to make sure that it gets tracked.

Environment:

  • kapp Controller version (execute kubectl get deployment -n kapp-controller kapp-controller -o yaml and the annotation is kbld.k14s.io/images):
  • Kubernetes version (use kubectl version)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@praveenrewar praveenrewar added bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli priority/important-soon Must be staffed and worked on currently or soon. labels May 11, 2022
@praveenrewar praveenrewar self-assigned this May 11, 2022
@praveenrewar praveenrewar linked a pull request May 30, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli priority/important-soon Must be staffed and worked on currently or soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant