Kubeapps should preserve comments from the original chart

[foal]

Description:

Kubeapps should preserve comments from the original chart. Now it lost the leading empty comment, e.g.

#
# Configure providers
#

turn into

# Configure providers
#

Steps to reproduce the issue:

1. Take, for example, the traefik 10.3.6 chart
2. Install it
3. Compare the values restored from k8s with the original values.

Describe the results you received:

Some differences found, because leads empty comments disappear

Describe the results you expected:

No difference in original and restored files except user changes

Version of Helm, Kubeapps and Kubernetes:

• Output of helm version:

version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}

• Output of helm list -n <kubeapps-namespace> <kubeapps-release-name>:

NAME            NAMESPACE       REVISION        UPDATED                                 STATUS          CHART           APP VERSION
kubeapps        kubeapps        3               2021-10-03 10:42:16.119406317 +0000 UTC deployed        kubeapps-7.5.2  2.4.0

• Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.2", GitCommit:"8b5a19147530eaac9476b0ab82980b4088bbc1b2", GitTreeState:"clean", BuildDate:"2021-09-15T21:38:50Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.2", GitCommit:"8b5a19147530eaac9476b0ab82980b4088bbc1b2", GitTreeState:"clean", BuildDate:"2021-09-15T21:32:41Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}

[antgamdia]

Hi @foal , thanks for using Kubeapps and reporting this issue. Unfortunately, I think I'm unable to reproduce it. I've installed it, updated it and restored it. Am I missing something?

issue3536.mp4

[foal]

Ok. I see.

I am able to reproduce the error starting from your state:

1. Click update
2. change

additionalArguments: []
#  - "--providers.kubernetesingress.ingressclass=traefik-internal"
#  - "--log.level=DEBUG"

to

additionalArguments: 
#  - "--providers.kubernetesingress.ingressclass=traefik-internal"
  - "--log.level=DEBUG"

3. deploy

[antgamdia]

Ah ok, got it. I've reproduced it.

I guess it is something related to how the JSON file is parsed and then converted into a YAML file using the dependencies. I'm not 100% sure if we can preserve these data, as it does not fully depend on us.