Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by repostiories for Carvel plugin #5168

Closed
antgamdia opened this issue Aug 4, 2022 · 0 comments · Fixed by #5172
Closed

Filter by repostiories for Carvel plugin #5168

antgamdia opened this issue Aug 4, 2022 · 0 comments · Fixed by #5172
Labels
component/plugin-carvel Issue related to kubeapps plugin to manage Carvel packages

Comments

@antgamdia
Copy link
Contributor

Summary
Currently, the "filter by repo" is not working* for carvel packages as we aren't really using this filter:

func FilterMetadatas(metadatas []*datapackagingv1alpha1.PackageMetadata, filterOptions *corev1.FilterOptions) []*datapackagingv1alpha1.PackageMetadata {
// Currently we support filtering by query or category but not by repository
// (UX doesn't yet display carvel repo in filter options).
// Once the UX does, we should be able to filter by repository
// also as its now an annotation:
// https://github.com/vmware-tanzu/carvel-kapp-controller/pull/532

(*) from a backend PoV, the UI is actually filtering, but from the whole list of packages.

Background and rationale
Once Carvel repos can be added via the UI we should support filtering by repos also in this plugin.

Description
Allow filtering by repo in carvel packages.

Acceptance criteria

  • The "filter by repos" is implemented in the plugin backend.

Additional context
Not critical as, feature-wise, it is actually working with the UI workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugin-carvel Issue related to kubeapps plugin to manage Carvel packages
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant