Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend usage of new clients provider in Kubeapps APIs #5362

Closed
castelblanque opened this issue Sep 20, 2022 · 0 comments · Fixed by #5405
Closed

Extend usage of new clients provider in Kubeapps APIs #5362

castelblanque opened this issue Sep 20, 2022 · 0 comments · Fixed by #5405
Assignees
@castelblanque
Labels
component/apis-server Issue related to kubeapps api-server go Pull requests that update Go code kind/enhancement An issue that reports an enhancement for an implemented feature
Milestone
Technical debt

Comments

@castelblanque
Copy link
Collaborator

castelblanque commented Sep 20, 2022 •
edited
Loading

Summary
In #5358 we introduced a new client provider/getter for K8s API calls from Helm plugin. We could extend that usage to the rest of plugins.

Description
The introduction of the new client getter allows to independently use any desired type of client from the Go source code. Previously it was necessary to generate them all at first, although only one was usually used.
This caused duplicated calls to K8s API to retrieve resources in the case of creating a dynamic client, for example.

Acceptance criteria

  • New client provider/getter is used throughout all plugins
@castelblanque castelblanque added kind/enhancement An issue that reports an enhancement for an implemented feature go Pull requests that update Go code component/apis-server Issue related to kubeapps api-server labels Sep 20, 2022
@castelblanque castelblanque self-assigned this Sep 22, 2022
@ppbaena ppbaena added this to the Technical debt milestone Sep 26, 2022
@castelblanque castelblanque mentioned this issue Sep 28, 2022
Merged
@ppbaena ppbaena closed this as completed Sep 28, 2022
@castelblanque castelblanque mentioned this issue Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@castelblanque castelblanque

Labels
component/apis-server Issue related to kubeapps api-server go Pull requests that update Go code kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Kubeapps
Archived in project
Milestone
Technical debt
Development

Successfully merging a pull request may close this issue.

New K8s clients provider for Kapp and Resources plugins vmware-tanzu/kubeapps
2 participants
@ppbaena @castelblanque