Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Overlay and Multi-AZ for legacy Windows #4215

Closed
wants to merge 1 commit into from
Closed

Overlay and Multi-AZ for legacy Windows #4215

wants to merge 1 commit into from

Conversation

knabben
Copy link
Member

@knabben knabben commented Dec 22, 2022 •
edited
Loading

What this PR does / why we need it

Adding multi-AZ MD spread for legacy Windows clusters

Which issue(s) this PR fixes

Fixes #4217

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

@knabben knabben requested review from a team as code owners December 22, 2022 20:01
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4215/20221222201441/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4215/20221222204324/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@knabben knabben changed the title [wip] Overlay and multi-az for legacy Windows Overlay and Multi-AZ for legacy Windows Dec 22, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4215/20221222225458/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Dec 22, 2022 •
edited
Loading

Codecov Report

Merging #4215 (4ec8d19) into main (a56516e) will decrease coverage by 0.88%.
The diff coverage is n/a.

❗ Current head 4ec8d19 differs from pull request most recent head adbaae2. Consider uploading reports for the commit adbaae2 to get more accurate results

@@            Coverage Diff             @@
##             main    #4215      +/-   ##
==========================================
- Coverage   49.31%   48.42%   -0.89%     
==========================================
  Files         450      480      +30     
  Lines       44577    46699    +2122     
==========================================
+ Hits        21982    22614     +632     
- Misses      20520    21960    +1440     
- Partials     2075     2125      +50
Impacted Files Coverage Δ
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
.../cli/plugin/cluster/get_machinehealthcheck_node.go 9.30% <0.00%> (ø)
cmd/cli/plugin/cluster/create.go 42.22% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
cmd/cli/plugin/isolated-cluster/test/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/upgrade.go 58.94% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
cmd/cli/plugin/cluster/set_machinehealthcheck.go 23.33% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4215/20221223003928/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4215/20221223014011/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@knabben knabben closed this Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi failure zones on Windows nodes
2 participants
@knabben @vmwclabot