Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc and code regarding restic #485

Closed
xing-yang opened this issue Oct 12, 2022 · 1 comment · Fixed by #500
Closed

Update doc and code regarding restic #485

xing-yang opened this issue Oct 12, 2022 · 1 comment · Fixed by #500
Assignees

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Oct 12, 2022

Describe the bug
In the upcoming Velero v1.10 along with the introduction to support kopia, some of the CLI parameters, resources are renamed:
Design doc: https://github.com/vmware-tanzu/velero/blob/main/design/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md

More details in the code change:
vmware-tanzu/velero#5370
vmware-tanzu/velero#5390
vmware-tanzu/velero#5432

We need to update the following doc section and test it:
https://github.com/vmware-tanzu/velero-plugin-for-vsphere/blob/main/docs/vanilla.md#backup-vsphere-cns-file-volumes

Command to install Velero with restic is changed:
https://github.com/vmware-tanzu/velero/blob/main/design/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md#installation

To Reproduce

[Steps to reproduce the behavior]

Expected behavior

[A clear and concise description of what you expected to happen]

Troubleshooting Information

[Please refer to the Troubleshooting page and collect the required information]

Screenshots

[If applicable, add screenshots to help explain your problem.]

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue]

@xing-yang
Copy link
Contributor Author

There are additional changes needed in vSphere plugin code. These changes are not Must Have, but they make plugin code consistent with the new Velero code:

  • Replace the call of restic.GetPodVolumesUsingRestic with podvolume.GetVolumesByPod. If this is not changed in plugin code, plugin has to refer to the old Velero code all the time, because in Velero 1.10, the function restic.GetPodVolumesUsingRestic has been deleted.
  • Remove the irrational appearance of “restic” word in plugin code/comments/logs.

Refer to this PR as an example of the aforementioned changes 1 and 2.

@xing-yang xing-yang changed the title Update doc regarding restic Update doc and code regarding restic Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants