Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third party BackupItemAction cannot support the VolumePolicy in v1.14.0 #7818

Closed
blackpiglet opened this issue May 23, 2024 · 0 comments · Fixed by #7969
Closed

third party BackupItemAction cannot support the VolumePolicy in v1.14.0 #7818

blackpiglet opened this issue May 23, 2024 · 0 comments · Fixed by #7969

Comments

@blackpiglet
Copy link
Contributor

blackpiglet commented May 23, 2024

Describe the problem/challenge you have

if groupResource == kuberesource.PersistentVolumeClaims &&
actionName == csiBIAPluginName {
snapshotVolume, err := ib.volumeHelperImpl.ShouldPerformSnapshot(obj, kuberesource.PersistentVolumeClaims)
if err != nil {
return nil, itemFiles, errors.WithStack(err)
}
if !snapshotVolume {
ib.trackSkippedPV(
obj,
kuberesource.PersistentVolumeClaims,
volumeSnapshotApproach,
"not satisfy the criteria for VolumePolicy or the legacy snapshot way",
log,
)
continue
}
}

Due to this logic check, the VolumePolicy is limited to the Velero CSI BIA, all the other BIA plugins cannot support the VolumePolicy, including the Velero vSphere plugin.

This is a known issue for Velero v1.14.0. The reason is the current BackupItemAction mechanism doesn't have an easy way to let the Velero pass in the VolumePolicy information into the BIA.
The next patch version of v1.14 will give a way to address it.

Describe the solution you'd like

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants