Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum type related changes #2

Merged
merged 2 commits into from
Aug 14, 2014
Merged

Enum type related changes #2

merged 2 commits into from
Aug 14, 2014

Conversation

dougm
Copy link
Member

@dougm dougm commented Aug 14, 2014

No description provided.

@dougm
Move generated enum types to their own file
29b2981 
- emit license header for generated files
@dougm
Don't use pointer for enum (string) fields
79f0006 
- change enum value decls from var to const
@pietern
Copy link
Contributor

pietern commented Aug 14, 2014

LGTM.

dougm added a commit that referenced this pull request Aug 14, 2014
@dougm
Merge pull request #2 from dougm/enums
20da5be 
Enum type related changes
@dougm dougm merged commit 20da5be into vmware:master Aug 14, 2014
tkak pushed a commit to tkak/govmomi that referenced this pull request Dec 27, 2014
@dougm
Merge pull request vmware#2 from dougm/enums
c661142 
Enum type related changes
caglar10ur added a commit that referenced this pull request Feb 16, 2017
@caglar10ur
Handle nil TaskInfo in task.Wait callback #2 (#666)
93064c0 
We loop over []types.PropertyChange slice and look for a certain name,
op and value before setting t.info.

t.info could be nil if we can't find a PropertyChange that fits into ruleset.
Handle that and also add a test to test that.
cgtexmex pushed a commit to cgtexmex/govmomi that referenced this pull request Mar 18, 2017
closes vmware#2
3f405b5
@MartinZJY MartinZJY mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougm @pietern