Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter events by type #976

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Conversation

dougm
Copy link
Member

@dougm dougm commented Dec 21, 2017

Filtering specific event types reduces the chance of missing events,
while keeping the event history collector page size on the low side.

Filtering specific event types reduces the chance of missing events,
while keeping the event history collector page size on the low side.
@dougm dougm merged commit 91fbd1f into vmware:master Dec 21, 2017
@dougm dougm deleted the event-types branch December 21, 2017 22:13
assert_success

run govc events -type VmPoweredOffEvent -type VmPoweredOnEvent "vm/$vm"
[ ${#lines[@]} -eq 2 ]
Copy link
Member

@hickeng hickeng Dec 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do with an additional VM operation (guest operation or reconfigure or something) so that you can assert that you do not get an event for it. Or use the power events but omit -type VmPoweredOffEvent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several events such as VmCreatedEvent, VmMacAssignedEvent, etc, are being filtered out here.. but yes could make it more explicit within the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants