Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Singleton Service][getRranslationWithPatternUsingGET] some fileds no parameter verification #373

Closed
nannany00 opened this issue Feb 7, 2020 · 3 comments
Assignees

Comments

@nannany00
Copy link
Contributor

Describe the bug
In Singleton Service APIs, there're some limitation for some request fileds, but for the new API:getRranslationWithPatternUsingGET, only productName,version have verification, other fileds no verification.

To Reproduce
Steps to reproduce the behavior:

  1. Get latest Singleton Service build, and start it;
  2. Go to API: GET/i18n/api/v2/combination/translationsAndPattern Get translations and patterns
  3. Check all the paramters for this API

Expected behavior
Should all parameters be verificated, keep consistent with other APIs.

Screenshots
NA

Desktop (please complete the following information):
NA

Additional context
NA

@nannany00
Copy link
Contributor Author

  1. "scope" is still not verified;
  2. Give a readable message when "combine" is not correct, now it's "The parameter is not pass the validate", please add which parameter is not pass.

@nannany00
Copy link
Contributor Author

nannany00 commented Apr 2, 2020

Parameter "scope" needs to be verificated whether the value is correct, not only unexpected characters.
Example, if set scope=date, "date" is not supported, only support "dates".

Will open a new issue to track this issue.

@nannany00
Copy link
Contributor Author

A new issue: #495

Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants