Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] G11n-java-client New workflow's Translation.getMessage must be able to use latest source messages from VIP service #812

Closed
jessiejuachon opened this issue Oct 2, 2020 · 1 comment · Fixed by #813
Assignees
Labels
kind/bug Something isn't working priority/high
Milestone

Comments

@jessiejuachon
Copy link
Contributor

jessiejuachon commented Oct 2, 2020

Describe the bug
TranslationMessage.getMessage is not able to fetch "latest" messages from VIP service and use them as source messages. This must be done as fallback for when messages_source.json is not supported locally.

To Reproduce
Steps to reproduce the behavior:

  1. Do not configure offline bundles' location in config.properties
  2. In VIP service, add new source strings to "latest", but not to "en" locale (a.k.a out-of-synch scenario)
  3. In the client, call TranslationMessage.getMessage("en", component, key);
  4. A VIP exception is thrown.

Expected behavior
Message that was added to "latest" in VIP service must be returned.

Additional context
This is to support use cases where source bundles are not together with the client code but instead are residing in other microservice's source code.

@jessiejuachon jessiejuachon added the kind/bug Something isn't working label Oct 2, 2020
@jessiejuachon jessiejuachon self-assigned this Oct 2, 2020
@jessiejuachon jessiejuachon added this to the Sprint 90 milestone Oct 2, 2020
@jessiejuachon jessiejuachon changed the title [BUG] G11n-java-client New workflow's Translation.getMessage must be able to fallback to "latest" messages from VIP service if messages_source.json is not present locally(offline) in the client [BUG] G11n-java-client New workflow's Translation.getMessage must be able to use latest source messages from VIP service Oct 14, 2020
@lyiyu66
Copy link

lyiyu66 commented Oct 20, 2020

The issue is fixed with commit bfb7deb.

@lyiyu66 lyiyu66 closed this as completed Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/high
Projects
None yet
2 participants