Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor vic-machine configure to avoid premature merge of old and new data #7818

Open
zjs opened this issue Apr 23, 2018 · 0 comments
Open

Refactor vic-machine configure to avoid premature merge of old and new data #7818

zjs opened this issue Apr 23, 2018 · 0 comments
Assignees
@zjs
Labels
area/cli The Vritual Container Host management CLI (vic-machine) component/install priority/p1 team/lifecycle triage/proposed-1.5

Comments

@zjs
Copy link
Member

zjs commented Apr 23, 2018 •
edited
Loading

As discussed in #7677 (review), configure is currently designed to operate only on the target/new configuration and has to work around the limitations of that design in a few places.

Instead, it should be adjusted to operate with additional information in a structured/consistent way (e.g., (old, delta, new)) so that the code is less fragile and case-by-case workarounds are not necessary.

This will probably block #6123.
@zjs zjs added area/cli The Vritual Container Host management CLI (vic-machine) component/install priority/p2 team/lifecycle status/needs-estimation The issue needs to be estimated by the team labels Apr 23, 2018
@zjs zjs self-assigned this Apr 23, 2018
@zjs zjs mentioned this issue Apr 23, 2018
Open
2 tasks
@andrewtchin andrewtchin removed the status/needs-estimation The issue needs to be estimated by the team label Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zjs zjs

Labels
area/cli The Vritual Container Host management CLI (vic-machine) component/install priority/p1 team/lifecycle triage/proposed-1.5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zjs @andrewtchin @sgairo