Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable output file #452

Closed
alexanderkoumis opened this issue Apr 22, 2023 · 3 comments · Fixed by #453
Closed

Configurable output file #452

alexanderkoumis opened this issue Apr 22, 2023 · 3 comments · Fixed by #453
Labels
enhancement New feature or request

Comments

@alexanderkoumis
Copy link
Contributor

The output file is not configurable. This becomes a problem when you output a file, open it up in a DAW (e.g. FL Studio), and want to bounce out a new converted voice file, causing a crash while writing because the file handle is still held by the DAW.

Recommended features:

  • A new output text box that allows specifying the output file
  • The default output filename should follow the same .out pattern as before, but have an automatically incrementing index if the output file already exists.

I've already implemented this and will be submitting a pull request shortly.

@alexanderkoumis alexanderkoumis added the enhancement New feature or request label Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 22, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 23, 2023
alexanderkoumis pushed a commit to alexanderkoumis/so-vits-svc-fork that referenced this issue Apr 23, 2023
@34j 34j closed this as completed in #453 Apr 23, 2023
34j pushed a commit that referenced this issue Apr 23, 2023
Co-authored-by: Alexander Koumis <alexanderkoumis@gmail.com>
@Arthur-McArthur
Copy link

how can we get the automatic increment filename to work?

@alexanderkoumis
Copy link
Contributor Author

how can we get the automatic increment filename to work?

This mechanism is triggered when the input file is selected, causing the default output filename to be generated. It guarantees the default output filename is unique when first generated. However, if inference is run multiple times with the same auto-generated output filename, the old tracks will be overwritten.

@Arthur-McArthur
Copy link

Thanks, it would be very useful if the output filename would automatically increment itself. File-out_2, File-out_3 etc. As it stands, if you intend to create multiple files you have to rename or move them after each inference which is inconvenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants