fix(utils): fix epoch variable name in checkpoint save/load functions #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there was a typo/mistake in the checkpoint save/load functions, and the variable was called
iteration
instead ofepoch
, and the same typo is present in the save/load log messages, which was confusing to users.As you can see in code below, we're actually passing
current_epoch
into save function.so-vits-svc-fork/src/so_vits_svc_fork/train.py
Lines 275 to 290 in ed3240a
I fixed that typo, but left it as an
iteration
in the actual torch data structure to maintain backward compatibility with existing checkpoint files for this model.