Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(easy-installation): fix .BAT installer error and update to cu118 #232

Merged
merged 5 commits into from
Apr 9, 2023

Conversation

ZeroHackz
Copy link
Contributor

chore(installer): fixed the installer crashing bug with simplified GPU checks and also updated cuDNN to cu118

…U checks and also updated cuDNN to cu118

chore(installer): fixed the installer crashing bug with simplified GPU checks and also updated cuDNN to cu118
@ZeroHackz ZeroHackz changed the title Fixed the .BAT installer crashing bug with simplified GPU checks and also updated cuDNN to cu118 chore(installer): Fixed the .BAT installer crashing bug with simplified GPU checks and also updated cuDNN to cu118 Apr 4, 2023
@ZeroHackz ZeroHackz changed the title chore(installer): Fixed the .BAT installer crashing bug with simplified GPU checks and also updated cuDNN to cu118 chore(installer): Fixed .BAT installer and cuDNN to cu118 Apr 4, 2023
@ZeroHackz ZeroHackz changed the title chore(installer): Fixed .BAT installer and cuDNN to cu118 fix(installer): Fixed .BAT installer and cuDNN to cu118 Apr 4, 2023
@34j
Copy link
Collaborator

34j commented Apr 5, 2023

fixed the installer crashing bug

Could you describe it in more detail?

@ZeroHackz
Copy link
Contributor Author

The current .BAT installer accessible from the README.md, didn't finish execution.

It couldn't finish because of the "%GPU%" guard usage failed to do a valid value check. I changed it on my local computer to this commit and it worked perfectly.

Furthermore I also updated the cuDNN to cu118 since the README.md manual setup also advised to do so.

commit 65aeb14
Merge: cce710f d561edb
Author: Exosfeer <exosfeer@protonmail.com>
Date:   Tue Apr 4 20:19:19 2023 +0200

    Merge branch 'main' of https://github.com/ZeroHackz/so-vits-svc-fork

commit cce710f
Author: Exosfeer <exosfeer@protonmail.com>
Date:   Tue Apr 4 20:19:12 2023 +0200

    chore(installer): fixed the installer crashing bug with simplified GPU checks and also updated cuDNN to cu118

    chore(installer): fixed the installer crashing bug with simplified GPU checks and also updated cuDNN to cu118
chore(cuDNN): updated feedback and links.
@codecov-commenter
Copy link

Codecov Report

Merging #232 (8c0fbf3) into main (d561edb) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   20.06%   20.10%   +0.04%     
==========================================
  Files          38       38              
  Lines        3210     3213       +3     
  Branches      416      421       +5     
==========================================
+ Hits          644      646       +2     
- Misses       2551     2552       +1     
  Partials       15       15              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@34j 34j changed the title fix(installer): Fixed .BAT installer and cuDNN to cu118 chore(easy-installation): fix .BAT installer error and cuDNN to cu118 Apr 9, 2023
@34j 34j changed the title chore(easy-installation): fix .BAT installer error and cuDNN to cu118 chore(easy-installation): fix .BAT installer error and update cuDNN to cu118 Apr 9, 2023
@34j 34j changed the title chore(easy-installation): fix .BAT installer error and update cuDNN to cu118 chore(easy-installation): fix .BAT installer error and update to cu118 Apr 9, 2023
@34j 34j merged commit 427712f into voicepaw:main Apr 9, 2023
@34j
Copy link
Collaborator

34j commented Apr 20, 2023

@allcontributors add ZeroHackz bug, code

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @ZeroHackz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants