Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle tab-closing (closing kernels) #173

Closed
SylvainCorlay opened this issue Jun 2, 2019 · 1 comment · Fixed by #525
Closed

Better handle tab-closing (closing kernels) #173

SylvainCorlay opened this issue Jun 2, 2019 · 1 comment · Fixed by #525

Comments

@SylvainCorlay
Copy link
Member

I am currently seeing some python errors in the terminal with respect to closing websockets.

@b060149ee
Copy link

I want the same thing.

I use Jupyter Lab and usually render my notebooks in voila using the "Render with voila" button available in the toolbar.

As each user's session is different and a separate kernel is opened for each session - can we please close the kernel when a voila tab is closed in Jupyter Lab? Currently, the only way to actually close voila kernels is by clicking 'Close and Shutdown' in the File Menu of the Jupyter Lab which is not intuitive. So auto-close of kernels on voila tab close is appreciated.

I understand this is not - for example a notebook's kernel behaves. But notebook kernels are shown in the 'Running' section. So either show the voila kernels in the 'Running' section or auto-close them on tab close. Thanks.

And I'm a big fan of Voila!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants