Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Content Security Policy (CSP) #29

Closed
astrojuanlu opened this issue Nov 28, 2018 · 6 comments
Closed

Configure Content Security Policy (CSP) #29

astrojuanlu opened this issue Nov 28, 2018 · 6 comments

Comments

@astrojuanlu
Copy link
Contributor

I was trying to access voila from a non-localhost IP and I was getting some CSP violations, so following @Carreau's advice here I added the following configuration:

--- /home/juanlu/.local/share/virtualenvs/poseidon-oYfLlCwx/src/voila/voila/app.py.old	2018-11-28 01:31:54.073333937 +0100
+++ /home/juanlu/.local/share/virtualenvs/poseidon-oYfLlCwx/src/voila/voila/app.py	2018-11-28 01:32:45.897266756 +0100
@@ -141,8 +141,7 @@
             jinja2_env=env,
             static_path='/',
             server_root_dir='/',
-            contents_manager=contents_manager
+            contents_manager=contents_manager,
+            headers={'Content-Security-Policy': "frame-ancestors 'self' http://host.eu"},
         )
 
         base_url = webapp.settings.get('base_url', '/')

Is there a better way to do it?

@maartenbreddels
Copy link
Member

Not for the moment, I think we should have a similar command line option though. Actually, we should think how we can reuse some of the notebook command line options.

@SylvainCorlay
Copy link
Member

This should already work when using as a notebook or jupyter_server extension.

Exposing these to the voila standalone app should not be difficult but it is not in yet.

@timkpaine
Copy link
Member

@Juanlu001 @SylvainCorlay @maartenbreddels WIP in #89, tests failing though, will work on it

@timkpaine
Copy link
Member

@Juanlu001 can you check if this is fixed by #69

@astrojuanlu
Copy link
Contributor Author

Sorry, not working with voila at the moment ☹️

@maartenbreddels
Copy link
Member

This should be fixed by #69 indeed, if not, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants