Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to voila as a Jupyter Server ExtensionApp #955

Open
jtpio opened this issue Sep 9, 2021 · 2 comments
Open

Switch to voila as a Jupyter Server ExtensionApp #955

jtpio opened this issue Sep 9, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 9, 2021

Problem

With the ExtensionApp now part of the latest Jupyter Server stable releases since 1.0, we should switch voila to using it.

Proposed Solution

There has already been a couple of PRs for this:

We could pick the more recent PR, rebase it, fix conflicts and continue from there.

Or start from scratch with a new PR (since there are a lot of conflicts), adding everyone who contributed before to the commits as co-authors.

Additional Context

We can track that for the 0.3.0 since it will most likely introduce some breaking changes.

@jtpio jtpio added the enhancement New feature or request label Sep 9, 2021
@jtpio jtpio added this to the 0.3.0 milestone Sep 9, 2021
@jtpio
Copy link
Member Author

jtpio commented Sep 24, 2021

cc @davidbrochart since you were the last one attempting such update, do you think it's better to pick up #592 or start over?

Also this is something that could be nice to have if we start having a fps plugin at some point: #977

@davidbrochart
Copy link
Member

Given the amount of conflicts, I think it is better to start over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants