This repository has been archived by the owner on Jul 7, 2019. It is now read-only.
Ignore nodes if out of syc. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
|
/cc @kinglion811 , @hex108 , @Jeffwan |
Jeffwan
reviewed
Jun 11, 2019
| @@ -549,6 +549,10 @@ func (sc *SchedulerCache) Snapshot() *kbapi.ClusterInfo { | |||
| } | |||
|
|
|||
| for _, value := range sc.Nodes { | |||
| if !value.Ready() { | |||
There was a problem hiding this comment.
Do we always track unready nodes? I am thinking if scheduler should delete node over timeout?
There was a problem hiding this comment.
Good point ! We should delete node if there's no pod on it when timeout :) I'm going to open a separate PR for that.
|
/approve |
volcano-sh-bot
added
the
approved
This was referenced Jun 11, 2019
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Ignore nodes if out of syc.
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Ignore nodes if out of syc.
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Ignore nodes if out of syc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Da K. Ma klaus1982.cn@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes kubernetes-retired#861
When kubelet was restarted, the device plugin may not report resource in time; so the volcano-sh/scheduler need ignore such kind of node to avoid panic.
The default scheduler does not have such kind of issue as there's not resources usage in node info.
Release note: