From 5b2289aefe5115c5b9e8aa8634878a22698c7594 Mon Sep 17 00:00:00 2001
From: TommyLike <hu.husheng@huawei.com>
Date: Fri, 5 Jul 2019 14:13:11 +0800
Subject: [PATCH] Update readme

---
 .gitignore           | 3 +++
 README.md            | 5 ++++-
 hack/run-e2e-kind.sh | 5 +++--
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index bb6e39ea3a..d2a68d6e6e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -125,3 +125,6 @@ kubernetes.tar.gz
 
 # e2e log files
 *.log
+
+# test coverage file
+coverage.txt
diff --git a/README.md b/README.md
index 46cd785047..3b391165df 100644
--- a/README.md
+++ b/README.md
@@ -106,9 +106,12 @@ volcanosh/vk-controllers   latest              7b11606ebfb8        10 seconds ag
 
 ``` 
 
-**NOTE**: You need ensure the images are correctly loaded in your kubernetes cluster, for
+**NOTE**:
+1. You need ensure the images are correctly loaded in your kubernetes cluster, for
 example, if you are using [kind cluster](https://github.com/kubernetes-sigs/kind), 
 try command ```kind load docker-image <image-name>:<tag> ``` for each of the images.
+2. When reinstall the volcano charts, since tiller server will not manage CRD resource,
+you need to delete them manually eg: `kubectl delete crds xxxx` before reinstalling or try command with `--no-crd-hook` option.
 
 ### 2. Helm charts
 
diff --git a/hack/run-e2e-kind.sh b/hack/run-e2e-kind.sh
index 27dfdc5e59..61e58f55ee 100755
--- a/hack/run-e2e-kind.sh
+++ b/hack/run-e2e-kind.sh
@@ -48,9 +48,10 @@ function install-volcano {
   kubectl create clusterrolebinding tiller-cluster-rule --clusterrole=cluster-admin --serviceaccount=kube-system:tiller
 
   echo "Install helm via script and waiting tiller becomes ready"
-  curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > get_helm.sh
+  HELM_TEMP_DIR=`mktemp -d`
+  curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > ${HELM_TEMP_DIR}/get_helm.sh
   #TODO: There are some issue with helm's latest version, remove '--version' when it get fixed.
-  chmod 700 get_helm.sh && ./get_helm.sh   --version v2.13.0
+  chmod 700 ${HELM_TEMP_DIR}/get_helm.sh && ${HELM_TEMP_DIR}/get_helm.sh   --version v2.13.0
   helm init --service-account tiller --kubeconfig ${KUBECONFIG} --wait
 
   echo "Pulling required docker images"