Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile cleanup #105

Closed
k82cn opened this issue Apr 26, 2019 · 9 comments
Closed

Makefile cleanup #105

k82cn opened this issue Apr 26, 2019 · 9 comments
Assignees
@TommyLike
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/high

Comments

@k82cn
Copy link
Member

k82cn commented Apr 26, 2019 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

Description:

It's better to support following targets in Makefile:

  1. make: only make related binaries, e.g. controller, scheduler
  2. make images: build related docker images
  3. make e2e-test-kind: run e2e test with kind
  4. make unit-test: run unit test
  5. make integration-test: run integration test
@k82cn
Copy link
Member Author

k82cn commented Apr 26, 2019

/cc @asifdxtreme @TommyLike

@k82cn
Copy link
Member Author

k82cn commented Apr 26, 2019

/kind bug
/priority high

@volcano-sh-bot volcano-sh-bot added kind/bug Categorizes issue or PR as related to a bug. priority/high labels Apr 26, 2019
@TommyLike
Copy link
Contributor

/assign

@TommyLike
Copy link
Contributor

/tell me why not working

@k82cn
Copy link
Member Author

k82cn commented Apr 28, 2019

xref #106

@k82cn
Copy link
Member Author

k82cn commented Apr 28, 2019

@TommyLike , would you help to check why #106 CI was failed? It seems admission controller is not enabled :(

@TommyLike
Copy link
Contributor

@k82cn sure.

@TommyLike
Copy link
Contributor

@k82cn it's failed once the helm plugin failed to approve csr via command kubectl certificate approve, see log:

certificatesigningrequest.certificates.k8s.io/integration-admission-service.kube-system approved
ERROR: After approving csr integration-admission-service.kube-system, the signed certificate did not appear on the resource. Giving up after 15 attempts.
Error: plugin "gen-admission-secret" exited with error

I didn't look deep into it, but it should varies depends on how faster when the cluster gets ready, and last time when I met it, I just increased the waiting time, would you please have a retry ?

@TommyLike
Copy link
Contributor

Fixed #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TommyLike TommyLike

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TommyLike @k82cn @volcano-sh-bot