New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added/Updated license for copied scripts. #228

Closed

k82cn opened this issue Jun 13, 2019 · 3 comments · Fixed by #230

Assignees

Labels

kind/bug priority/high

Member

k82cn commented Jun 13, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

Description:

Some license is in-correct to me, please help to update them:

https://github.com/volcano-sh/volcano/blob/master/hack/update-gencode.sh , AFAIK, we re-used this script from k8s, we should keep k8s's copyright.
https://github.com/volcano-sh/volcano/blob/master/hack/verify-gofmt.sh , https://github.com/volcano-sh/volcano/blob/master/hack/verify-golint.sh : we should add k8s license to those two scripts.

Member Author

k82cn commented Jun 13, 2019

/assign @asifdxtreme

volcano-sh-bot assigned asifdxtreme

Member Author

k82cn commented Jun 13, 2019

/kind bug
/priority high

volcano-sh-bot added kind/bug priority/high labels

Contributor

asifdxtreme commented Jun 14, 2019

Rajadeepan mentioned this issue

Added/Updated license for copied scripts #230

Merged

volcano-sh-bot closed this as completed in #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment