Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid version conversion cross the components #595

Closed
k82cn opened this issue Dec 10, 2019 · 0 comments
Closed

Avoid version conversion cross the components #595

k82cn opened this issue Dec 10, 2019 · 0 comments
Assignees
@k82cn
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.4

Comments

@k82cn
Copy link
Member

k82cn commented Dec 10, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Description:

For now, we did version conversion by hard code cross different components in the project, which makes it hard to maintain; it's better to leverage crd versioning feature to do that. Refer to the following link on how to do that: https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definition-versioning/ .
@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 10, 2019
@k82cn k82cn added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 10, 2019
@k82cn k82cn added this to the v0.3 milestone Dec 10, 2019
@k82cn k82cn self-assigned this Dec 10, 2019
@k82cn k82cn changed the title Avoid version conversion cross the project Avoid version conversion cross the components Dec 10, 2019
@k82cn k82cn modified the milestones: v0.3, v0.4 Dec 19, 2019
@k82cn k82cn mentioned this issue Jan 6, 2020
Merged
This was referenced Jan 27, 2020
Closed
Closed
@k82cn k82cn closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k82cn k82cn

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Added crd conversion. k82cn/volcano
2 participants
@k82cn @volcano-sh-bot