Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The docker image name should align with binaries' #72

Closed
k82cn opened this issue Apr 7, 2019 · 3 comments · Fixed by #78
Closed

The docker image name should align with binaries' #72

k82cn opened this issue Apr 7, 2019 · 3 comments · Fixed by #78
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v0.1

Comments

@k82cn
Copy link
Member

k82cn commented Apr 7, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind cleanup

Description:

In Makefile, our binaries are vk-controller, vk-scheduler and so on; but the docker image is volcanosh/volcano-scheduler. It's better to make them align with each other to avoid confusion.

/cc @asifdxtreme
@k82cn k82cn added this to the v0.1 milestone Apr 7, 2019
@k82cn k82cn added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 7, 2019
@asifdxtreme
Copy link
Contributor

@k82cn , yes we can change the name of the docker repo, so the new name is :

volcanosh/vk-scheduler
volcanosh/vk-controllers
volcanosh/vk-admission

are these name okay?

@k82cn
Copy link
Member Author

k82cn commented Apr 8, 2019

@asifdxtreme , yes, vk-* is ok to me :)

@asifdxtreme
Copy link
Contributor

the same has been updated with latest & 0.1 tags
image

I will send an another PR for updating the release scripts

@asifdxtreme asifdxtreme mentioned this issue Apr 8, 2019
Merged
@k82cn k82cn closed this as completed in #78 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.1
Development

Successfully merging a pull request may close this issue.

Update scripts as per docker image volcano-sh/volcano
2 participants
@asifdxtreme @k82cn