-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "engines" field as fallback #924
Comments
Hi @iwt-nduesing, thanks for asking! You're right that issue outlines some of the reasons why we don't use engines. I think this comment: #742 (comment) also goes into more details about the technical and conceptual reasons why we chose not to support engines. Unfortunately, I think those limitations apply equally to using it as a fallback; especially the limitation of how we resolve a version range, given that one of Volta's goals is to allow for repeatable builds. Related, there is ongoing discussion in #282 about supporting a separate file, which could combine with |
I don't agree with the reasoning. At least #282 would solve some of them. Some of my reasons are not solved and weight more in my eyes. But I accept the decision. Thanks for considering and the fast response. |
The ergonomic concerns about keeping the versions in sync are definitely valid and I wonder if there's a way we can ease up that by providing some command to sync them. It would still require someone to run a command, but there may be a way to make it a one-liner that someone can run as they update |
In #355 is already explained why a new
volta
field was introduced additionally to theengines
field (documentation of npm and yarn). I don't like to replace thevolta
config but I like to suggest to use theengines
field as fallback for the following reasons:volta
field. So the system node version is used. Especially old projects run with older node versions. So initially the wrong version is used.package.json
.engines
version (if using Semver) needs to be updated less often than thevolta
version.The text was updated successfully, but these errors were encountered: