Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VxAdmin: Large tally reports, with lots of groups, fail to generate #5278

Closed
arsalansufi opened this issue Aug 19, 2024 · 0 comments · Fixed by #5343
Closed

VxAdmin: Large tally reports, with lots of groups, fail to generate #5278

arsalansufi opened this issue Aug 19, 2024 · 0 comments · Fixed by #5343

Comments

@arsalansufi
Copy link
Contributor

arsalansufi commented Aug 19, 2024

With a large election, the “All Precincts Tally Report” fails to generate (spins for a while, then goes to “something went wrong”)

Log output:

[backend:run] {"source":"vx-admin-service","eventId":"election-report-previewed","eventType":"user-action","user":"election_manager","message":"User previewed a tally report.","disposition":"success"}
[backend:run] page.setContent: Target page, context or browser has been closed
[backend:run] Call log:
[backend:run]   - setting frame content, waiting until "load"
[backend:run] 
[backend:run]     at renderToPdf (/home/jonahkagan/code/vxsuite/libs/printing/build/render.js:87:20)
[backend:run]     at async generateTallyReportPreview (/home/jonahkagan/code/vxsuite/apps/admin/backend/build/reports/tally_report.js:80:14)
[backend:run]     at /home/jonahkagan/code/vxsuite/apps/admin/backend/async /home/jonahkagan/code/vxsuite/libs/grout/build/server.js:92:32

Issue automatically created from Slack feedback reported by jonah:
https://votingworks.slack.com/archives/CJU9MSC6S/p1723747765653159?thread_ts=1723747765.653159&cid=CJU9MSC6S


This issue seems to affect any report generation involving a group-by on a field with many distinct values. We can try to fix this, but just blocking report generation for unreasonably large group-by's is fine, too. We can record this as one of our system limits.

Another example here:

VxAdmin something went wrongs when reporting (tally report) grouped by batch when there are an insane (10,000) number of batches. Ballot count report grouped by batch succeeds after several minutes

@adghayes adghayes changed the title With a large election, the “All Precincts Tally Report” fails to generate (spins for a while, then goes to “something went wrong”) Log output: ```[backend:run] {"source":"vx-admin-service","eventId":"election-report-previewed","eventType":"user-action","user":"election_manager","message":"User previewed a tally report VxAdmin: Large tally reports, with lots of groups, fail to generate Aug 19, 2024
@adghayes adghayes added this to the v4.0 - Final milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants