Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept ballots when continuous export is disabled and no USB drive is connected #5526

Open
arsalansufi opened this issue Oct 16, 2024 · 1 comment
Open

Accept ballots when continuous export is disabled and no USB drive is connected #5526

arsalansufi opened this issue Oct 16, 2024 · 1 comment
Assignees
@arsalansufi
Labels
bug
Milestone
v4.0 - Final

Comments

@arsalansufi
Copy link
Contributor

arsalansufi commented Oct 16, 2024 •
edited
Loading

In v4, if you disable continuous export and remove the USB drive, we properly don't display the "No USB drive detected" screen. But we also don't accept any ballots until a USB drive is reconnected. This works as expected in v3 and you can scan without a USB drive connected when you pause continuous export. I missed a case in this new isReadyToScan function in my up-port from v3 to v4.

Issue automatically created from Slack feedback reported by arsalan:
https://votingworks.slack.com/archives/CJU9MSC6S/p1728610432894339?thread_ts=1728610432.894339&cid=CJU9MSC6S
@mattroe mattroe added bug and removed triage labels Oct 16, 2024
@mattroe mattroe added this to the v4.0 - Final milestone Oct 16, 2024
@adghayes adghayes changed the title In v4, if you disable continuous export and remove the USB drive, we properly don't display the "No USB drive detected" screen Ensure we show "No USB Drive Detected" screen even when continuous export disabled Oct 16, 2024
@adghayes adghayes mentioned this issue Oct 17, 2024
Closed
@arsalansufi arsalansufi self-assigned this Oct 18, 2024
@arsalansufi
Copy link
Contributor Author

Posted my reasoning for switching back to the original intent here! #5536 (comment)

@arsalansufi arsalansufi changed the title Ensure we show "No USB Drive Detected" screen even when continuous export disabled Accept ballots when continuous export is disabled and no USB drive is connected Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arsalansufi arsalansufi

Labels
bug
Projects
None yet
Milestone
v4.0 - Final
Development

Successfully merging a pull request may close this issue.

show no usb drive detected screen even when continuous export disabled votingworks/vxsuite
2 participants
@mattroe @arsalansufi