Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash of downloaded binary never verified #116

Closed
centromere opened this issue May 7, 2015 · 8 comments
Closed

Hash of downloaded binary never verified #116

centromere opened this issue May 7, 2015 · 8 comments
Labels
enhancement New feature or request wontfix

Comments

@centromere
Copy link

When installing from a URL, the hash of the file is never verified. This would be a really nice feature to have.

@solarkennedy
Copy link
Contributor

Hmmm. Are you looking for security or just integrity?

@centromere
Copy link
Author

Both.

@solarkennedy
Copy link
Contributor

I think that would be best served in a non-consul specific way inside the module we use to download and unzip the thing:
https://github.com/nanliu/puppet-staging

It could take some sort of verification url?

staging::deploy { 'the zip':
  source => download_url,
  target => target_dir,
  creates => consul,
  verfication_url => "https://dl.bintray.com/mitchellh/consul/${version}_SHA256SUMS?direct",
  verification_method => "sha256sum",
}

@centromere
Copy link
Author

There's a module called puppet-archive which has checksum verification built in.

@solarkennedy
Copy link
Contributor

Ooo!!

@hopperd hopperd added the enhancement New feature or request label Mar 25, 2016
@solarkennedy
Copy link
Contributor

We now use puppet-archive, so I would accept a PR that enables verification.

@solarkennedy
Copy link
Contributor

We are now officially using the latest version of puppet-archive, so this is actually possible if someone wants to try.

https://github.com/voxpupuli/puppet-archive#archive

With checksum_verify and related options for pointing the module at the right checksum url.

@stale
Copy link

stale bot commented Aug 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 21, 2020
@stale stale bot closed this as completed Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix
Projects
None yet
Development

No branches or pull requests

3 participants