-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash of downloaded binary never verified #116
Comments
Hmmm. Are you looking for security or just integrity? |
Both. |
I think that would be best served in a non-consul specific way inside the module we use to download and unzip the thing: It could take some sort of verification url? staging::deploy { 'the zip':
source => download_url,
target => target_dir,
creates => consul,
verfication_url => "https://dl.bintray.com/mitchellh/consul/${version}_SHA256SUMS?direct",
verification_method => "sha256sum",
} |
There's a module called puppet-archive which has checksum verification built in. |
Ooo!! |
We now use puppet-archive, so I would accept a PR that enables verification. |
We are now officially using the latest version of puppet-archive, so this is actually possible if someone wants to try. https://github.com/voxpupuli/puppet-archive#archive With |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When installing from a URL, the hash of the file is never verified. This would be a really nice feature to have.
The text was updated successfully, but these errors were encountered: