Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update puppetlabs-concat dependency #351

Closed
linuxmail opened this issue Aug 4, 2017 · 4 comments · Fixed by #330
Closed

Review and update puppetlabs-concat dependency #351

linuxmail opened this issue Aug 4, 2017 · 4 comments · Fixed by #330
Assignees

Comments

@linuxmail
Copy link

linuxmail commented Aug 4, 2017

Hi,

just a question: must the Concat version older than 3.0.0 ? I had to change it, otherwise I wasn't able to upgrade Concat to the latest version for other modules.

cu denny

{ "name": "puppetlabs/concat", "version_requirement": ">= 2.0.1 < 3.0.0" },
@lbetz
Copy link
Contributor

lbetz commented Aug 4, 2017

Should work but our tests are broken at the moment.

@lazyfrosch
Copy link
Contributor

Also see #330

@cfoehrdes
Copy link

We are also experiencing lots of conflicts due to the restriction to this old concat release

@lazyfrosch lazyfrosch changed the title { "name": "puppetlabs/concat", "version_requirement": ">= 2.0.1 < 3.0.0" }, Review and update puppetlabs-concat dependency Aug 7, 2017
@lazyfrosch lazyfrosch self-assigned this Aug 7, 2017
@cristianbalan-mf
Copy link

cristianbalan-mf commented Sep 1, 2017

@lazyfrosch, concat released a mix 3.0.0 and 4.0.0. While 4 can be seen as a port to P5, there's no reason for Icinga's module not to satisfy at least concat 3.
Concat 2 is just P3... :(

This double release adds new Puppet 4 data types. The 3.0.0 release is fully backwards compatible to existing Puppet 4 configurations and provides you with deprecation warnings for every argument that will not work as expected with the final 4.0.0 release. See the stdlib docs for an in-depth discussion of this.
If you're still running Puppet 3, remain on the latest puppetlabs-concat 2.x release for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants