add support for mongodb 5.0 for debian #623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
requested changes
Sep 4, 2021
There was a problem hiding this comment.
Can you please address the CI failure?
When done, can you please combine your commits in a single one?
From your working directory:
git rebase -i origin/master # Interactively rewrite history
This will bring your editor. Keep the first line unchanged, and replace pick with squash for all subsequent lines. Save and quit, your editor will allow you to combine the commit messages in a single commit message.
Then push your updated branch:
git push -f # Send the changes (-f is required because we re-wrote history)
fix missing provider Update lib/puppet/provider/mongodb.rb Co-authored-by: Romain Tartière <romain@blogreen.org> Use empty lines between method definitions remove trailing whitespace
hdep
force-pushed
the
support-mongodb5
branch
from
09f913e to
d28e0d4
Compare
|
@smortex done ! |
smortex
approved these changes
Sep 6, 2021
|
any change to get this merge soon ? thank you |
|
nope, this was done because #615 was inactive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds apt key for debian/ubuntu mongo repo for mongodb version 5.0
This Pull Request (PR) fixes the following issues
same PR as #615 fix #614