Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resourcejson #398

Closed
felipegules opened this issue Aug 29, 2018 · 2 comments
Closed

Add resourcejson #398

felipegules opened this issue Aug 29, 2018 · 2 comments

Comments

@felipegules
Copy link

felipegules commented Aug 29, 2018

  • Puppet: 3.8.7
  • Ruby: 2.0.0p648
  • Distribution: centos7
  • Module version: 5.3.0

How to reproduce (e.g Puppet code you use)

Add resource_source JSON extension
resource_format: 'resourcejson'

Any additional information you'd like to impart

diff --git a/modules/rundeck/manifests/config/resource_source.pp b/modules/rundeck/manifests/config/resource_source.pp

--- a/modules/rundeck/manifests/config/resource_source.pp
+++ b/modules/rundeck/manifests/config/resource_source.pp
@@ -81,7 +81,7 @@ define rundeck::config::resource_source(
   String $mapping_params                                         = '',
   Integer $number                                                = 1,
   Optional[String] $project_name                                 = undef,
-  Enum['resourcexml', 'resourceyaml'] $resource_format           = $rundeck::params::resource_format,
+  Enum['resourcexml', 'resourceyaml', 'resourcejson'] $resource_format = $rundeck::params::resource_format,
   Boolean $running_only                                          = true,
   String $script_args                                            = '',
   Boolean $script_args_quoted                                    = $rundeck::params::script_args_quoted,
@@ -154,6 +154,9 @@ define rundeck::config::resource_source(
         'resourceyaml': {
           $file_extension = 'yaml'
         }
+        'resourcejson': {
+          $file_extension = 'json'
+        }
         default: {
           err("The rundeck resource model resource_format ${resource_format} is not supported")
         }
@bastelfreak
Copy link
Member

Hi @felipegules , thanks for creating this issue. Can you create a PR with this code?

@kenyon
Copy link
Member

kenyon commented Dec 4, 2023

Obsoleted by #520.

@kenyon kenyon closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants