Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SphereCollider ctor make lot of gc #843

Closed
Personuo opened this issue Apr 4, 2021 · 3 comments
Closed

SphereCollider ctor make lot of gc #843

Personuo opened this issue Apr 4, 2021 · 3 comments
Milestone

Comments

@Personuo
Copy link

Personuo commented Apr 4, 2021

SphereCollider ctor use Mathf.Max(x,y,z), this function will generate a lot of gc,
pls Fix it to Mathf.Max(Mathf.Max(x,y),z);
thank you.

@Personuo Personuo changed the title SphereCollider ceator make lot of gc SphereCollider ctor make lot of gc Apr 4, 2021
@Personuo
Copy link
Author

Personuo commented Apr 4, 2021

Similarly, I found this problem in (VRMSpringBoneColliderGroup.UniformedLossyScale), but since this is not executed under update, it doesn't seem to have much effect

@ousttrue ousttrue added this to the v0.72 milestone Apr 5, 2021
@ousttrue
Copy link
Contributor

public static float Max(params float[] values); cause array GC

@ousttrue
Copy link
Contributor

Fixed in v0.72.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants