Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review letter spacing tokens after Inter font was updated #1821

Closed
davicostalf opened this issue Aug 13, 2024 · 5 comments
Closed

Review letter spacing tokens after Inter font was updated #1821

davicostalf opened this issue Aug 13, 2024 · 5 comments
Assignees
Labels
design Indicates that the issue or pull request involves design considerations proposal Proposals for enhancements to the software

Comments

@davicostalf
Copy link
Contributor

davicostalf commented Aug 13, 2024

Google Fonts updated the Inter font family to the latest release (v4). One of the major changes was the addition of a optical size axis, which is set to auto by default. Since we were previously defining letter spacing manually based on font size we need to review if this is still necessary or at least review if the token values still make sense.

@davicostalf davicostalf added design Indicates that the issue or pull request involves design considerations idea Suggestions or requests for enhancements to the software labels Aug 13, 2024
@davicostalf
Copy link
Contributor Author

Test in Figma and code (apply --sl-letter-spacing-1 to all typography tokens?)

@davicostalf davicostalf added proposal Proposals for enhancements to the software and removed idea Suggestions or requests for enhancements to the software labels Sep 17, 2024
@davicostalf davicostalf self-assigned this Sep 17, 2024
@davicostalf
Copy link
Contributor Author

Did some digging:

  • We can use the story of the Text component in storybook to review letter spacing changes (current, 0rem)
  • The new optical size axis gets us closer to the values we had defined previously, but there's still a difference.
  • Figma hasn't updated the Inter font to the 4.0 version.

Open questions:

  • We have to decide if we are going to stick with the definitions of the font family or still implement some letter spacing adjustment.
  • We have to decide if we are going to use different letter spacing values in Figma to match with the code (since the font version is outdated) or try to update the font in the Figma organization by uploading the new version.

I'm current leaning towards leaving Figma as is and updating the letter spacing tokens application so they match with what had been previously defined. When Figma updates the font version we make these adjustments there.

@beatrizmilhomem
Copy link
Contributor

I'm current leaning towards leaving Figma as is and updating the letter spacing tokens application so they match with what had been previously defined. When Figma updates the font version we make these adjustments there.

lgtm

@davicostalf
Copy link
Contributor Author

davicostalf commented Sep 18, 2024

  • Investigate if token values will need to be updated
  • Add disclaimer in Figma library about letter spacing values

@davicostalf
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Indicates that the issue or pull request involves design considerations proposal Proposals for enhancements to the software
Projects
Status: Done
Development

No branches or pull requests

2 participants