Attack bonus is now also added to damage.

[NachoTeller]

What happened?

On weapons, the Bonus box was for the attack roll only, and the Damage box is for Damage only. Now in the results, the bonus is automatically being added to the damage result.

Image 1
Imgur

Image 2
Imgur

What is the expected behaviour?

The Bonus box on Weapons and Attacks MUST NOT BE ADDED to the Damage roll

Relevant Errors and Warnings

This has caused me to have over 100 bad monster sheets right now, and every character sheet in my party has all their weapons with wrong rolls.

I consider this to be a Critical Bug in the game system.

Additional Support Details

No response

Foundry VTT Core Version

V10

Old-School Essentials Core Version

Last

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Firefox, Chrome, Microsoft Edge

Code of Conduct

• I agree to follow this project's Code of Conduct

[justinthejaguar]

IIRC, Anthony updated the character sheets to have a tweak that makes the bonuses work the way that they did before.

[justinthejaguar]

@anthonyronda It might be beneficial to make it a game setting rather than an individual actor setting.

[NachoTeller]

It seems disproportionate to me and it should be the other way round. It is a change that affects all the actors and there is no way to change it in general but it has to be done 1 by 1. Do I have to do it with the whole bestiary? It's almost like destroying years of work.

[justinthejaguar]

It is an inconvenience, but let's be clear that nothing is destroyed. Your assets are intact, and you can use a prior release of the game. https://github.com/vttred/ose/releases/tag/1.8.2

[NachoTeller]

@justinthejaguar What I mean is that I have to update all the monster tokens and all the character tokens and tick the box. And the problem is not that, it's that with the monsters, the tokens are not linked to the token (obviously because if there are 50 goblins they are not all going to be synchronised equally) and I have 14 dungeon floors that I just finished preparing today (6 months of work and almost 2000 tokens).

[NachoTeller]

@anthonyronda I've been testing with the "Don't apply bonuses" checkbox checked, and it turns out that even melee attack rolls don't add the Strength bonus to the damage.

[anthonyronda]

Certainly don't make changes to your whole bestiary one by one. We can help with whichever issue you're facing either by providing a macro to complete a migration in a single action, or consider alternatives such as the world setting as mentioned

[anthonyronda]

justinthejaguar What I mean is that I have to update all the monster tokens and all the character tokens and tick the box. And the problem is not that, it's that with the monsters, the tokens are not linked to the token (obviously because if there are 50 goblins they are not all going to be synchronised equally) and I have 14 dungeon floors that I just finished preparing today (6 months of work and almost 2000 tokens).

The change we made here is possibly worthy of a database migration, a process of changing all actor document data in the world/compendiums (tokens included) to reflect the correct behavior under the changed code. However, there's no obviously correct way for me to do this right now. Different GMs have different expectations and different ways they created their worlds. I'll think about it and hear suggestions.

@anthonyronda I've been testing with the "Don't apply bonuses" checkbox checked, and it turns out that even melee attack rolls don't add the Strength bonus to the damage.

I understand, this is unintended. I will fix this as a bug