Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(site): fix broken rule menu links #857

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

ota-meshi
Copy link
Contributor

Clicking on the rules menu on the new site shows a 404 page.
This PR fixes that broken link.

@vhoyer
Copy link
Collaborator

vhoyer commented Jul 25, 2023

do both middle and left click open the page correctly?

@vhoyer
Copy link
Collaborator

vhoyer commented Jul 25, 2023

anyway, that constant is used only on one other place, if we are removing it from rulesFromSidebar, we should also remove it from the constants file and just use it directly on the other file, can you fix it?

@ota-meshi
Copy link
Contributor Author

do both middle and left click open the page correctly?

Yes.

we should also remove it from the constants file and just use it directly on the other file, can you fix it?

I removed constants.ts.

Copy link
Collaborator

@vhoyer vhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@vhoyer vhoyer merged commit 327222d into vue-a11y:main Jul 26, 2023
2 checks passed
@ota-meshi ota-meshi deleted the fix branch July 26, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants