Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark theme #3410

Merged
merged 6 commits into from
Jan 14, 2021
Merged

feat: dark theme #3410

merged 6 commits into from
Jan 14, 2021

Conversation

zkwolf
Copy link
Member

@zkwolf zkwolf commented Dec 19, 2020

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@zkwolf zkwolf marked this pull request as draft December 19, 2020 17:01
@zkwolf zkwolf marked this pull request as ready for review December 20, 2020 10:50
@zkwolf zkwolf marked this pull request as draft December 20, 2020 16:30
@zkwolf zkwolf marked this pull request as ready for review December 20, 2020 17:05
@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

分隔符看不到了

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

多了一个框的背景

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

禁用的感觉也应该有个边框

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

有一个 icon 看不到了

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

字体颜色

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

这个在点击的 时候 底层的 icon 能看到 和主题无关 的 bug 先记录下

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

悬浮的时候,感觉颜色有闪动

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

表格最后一行 padding-bottom 有问题,是不是没同步还是啥?

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

抽屉 默认打开的 body 颜色可以处理一下

@xrkffgg
Copy link
Member

xrkffgg commented Jan 8, 2021

image

圆形的 空着部分 默认颜色 白色 有点太亮

Copy link
Member

@xrkffgg xrkffgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该没问题,有用户提再说

@tangjinzhou tangjinzhou mentioned this pull request Jan 14, 2021
13 tasks
@tangjinzhou tangjinzhou merged commit b07190e into vueComponent:next Jan 14, 2021
@zkwolf zkwolf deleted the update-style branch January 28, 2021 17:16
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants