Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): add new features #5479

Merged
merged 13 commits into from
Apr 14, 2022
Merged

Conversation

buqiyuan
Copy link
Member

@buqiyuan buqiyuan commented Apr 10, 2022

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

before:

before.mp4

after:

after.mp4

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@buqiyuan buqiyuan changed the title refactor(image): refactor & add new features feat(image): add new features Apr 11, 2022
components/image/__tests__/__snapshots__/demo.test.js.snap Outdated Show resolved Hide resolved
components/image/index.tsx Outdated Show resolved Hide resolved
components/image/index.zh-CN.md Outdated Show resolved Hide resolved
components/vc-image/src/Image.tsx Outdated Show resolved Hide resolved
components/vc-image/src/Image.tsx Outdated Show resolved Hide resolved
components/vc-image/src/Image.tsx Outdated Show resolved Hide resolved
components/vc-image/src/Preview.tsx Outdated Show resolved Hide resolved
components/vc-image/src/PreviewGroup.tsx Outdated Show resolved Hide resolved
@tangjinzhou
Copy link
Member

image
这两都没过

@buqiyuan
Copy link
Member Author

buqiyuan commented Apr 13, 2022

image 这两都没过

😂同步了下rc-dialog rootClassName,代码里面没提示缺少这个属性 没注意

@Fox-ABC
Copy link

Fox-ABC commented Apr 13, 2022

这个版本什么时候会发布

@tangjinzhou tangjinzhou merged commit bd87079 into vueComponent:main Apr 14, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants