Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to use compile beceause of new tests #1245

Closed
TheSirC opened this issue Jan 13, 2018 · 5 comments
Closed

Impossible to use compile beceause of new tests #1245

TheSirC opened this issue Jan 13, 2018 · 5 comments
Assignees
Labels

Comments

@TheSirC
Copy link

TheSirC commented Jan 13, 2018

Hello,

I am unable to compile any file based of this template because of this commit (fd65d24) : the file now throws back an error

index.js:16
    ...(isTest ? scenario : undefined)
    ^^^

SyntaxError: Unexpected token ...
    at createScript (vm.js:74:10)
    at Object.runInThisContext (vm.js:116:10)
    at Module._compile (module.js:533:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/sirc/.vue-templates/webpack/meta.js:14:28)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)

Sorry for the bug ! 😞

@LinusBorg
Copy link
Contributor

The template tests require node >=8.

I'll update the engines field in package.json accordingly.

@LinusBorg
Copy link
Contributor

LinusBorg commented Jan 13, 2018

Edit: oh snap, I'm an idiot!

that code also runs on normal template installs! And those should of course not require node 8

I'll fix this in the next hours.

@LinusBorg LinusBorg added the bug label Jan 13, 2018
@LinusBorg LinusBorg self-assigned this Jan 13, 2018
LinusBorg added a commit that referenced this issue Jan 13, 2018
* develop:
  Bump template version (1.3.1)
  change circleci node image to 6.12.3 to ensure node 6 compat.
  replace object rest spread with Object.assign for node6 compat. (fix #1245)
@LinusBorg
Copy link
Contributor

Found a few minutes right now, and it's fixed!

Thanks for the report @TheSirC

@TheSirC
Copy link
Author

TheSirC commented Jan 14, 2018

You're welcome!
You're doing a wonderful job! Thank you!

@LinusBorg
Copy link
Contributor

Thanks :)

c0defre4k pushed a commit to neonblack-at/webpack that referenced this issue Jan 23, 2018
* vuejs-templates/master: (66 commits)
  Bump template version (1.3.1)
  change circleci node image to 6.12.3 to ensure node 6 compat.
  replace object rest spread with Object.assign for node6 compat. (fix
vuejs-templates#1245)
  bump template version (1.3.0)
  chore: remove extra comma (vuejs-templates#1240)
  Improve template CI tests (close vuejs-templates#1218)
  Revert "fix bad alias (fix vuejs-templates#1239)"
  Typo, whitespace and Style Guide fixes (vuejs-templates#1231)
  Update runner.js (vuejs-templates#1235)
  remove unnecessary option.
  bumping eslint dependencies
  fix bad alias (fix vuejs-templates#1239)
  fix history fallback for windows.
  remove duplicate lines in gitignore (vuejs-templates#1214)
  fix historyFallback rewrite for Windows systems
  improved comments in eslintrc
  updated linting docs.
  respect eslint rule for order of options.
  switch to essential ruleset.
  add eslint-plugin-vue
  ...

# Conflicts:
#	meta.js
#	template/package.json
#	template/src/components/HelloWorld.vue
#	template/src/main.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants