Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): fix call sequence of ontrigger in effect #10501

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

@OnlyWick
Copy link
Contributor Author

onTrigger of computed has also been disrupted. I believe computed should also be directly tracked(for support onTrigger).

@yyx990803
Copy link
Member

Good catch. I made some small adjustments to make the head logic dev-only.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 93.9 kB (+3.16 kB) 35.4 kB (+937 B) 31.9 kB (+830 B)
vue.global.prod.js 151 kB (+3.16 kB) 54.7 kB (+946 B) 48.8 kB (+756 B)

Usages

Name Size Gzip Brotli
createApp 53.9 kB (+3.17 kB) 20.9 kB (+1.01 kB) 18.9 kB (+840 B)
createSSRApp 57.3 kB (+3.17 kB) 22.2 kB (+984 B) 20.1 kB (+804 B)
defineCustomElement 56.2 kB (+3.17 kB) 21.6 kB (+1 kB) 19.6 kB (+805 B)
overall 67.6 kB (+3.14 kB) 25.8 kB (+930 B) 23.4 kB (+829 B)

@yyx990803 yyx990803 merged commit 28841fe into vuejs:minor Apr 25, 2024
7 checks passed
@OnlyWick OnlyWick deleted the fix-call-sequence-of-ontrigger branch April 25, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants