Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types/defineModel): allow getter and setter types to be unrelated #11699

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

jh-leong
Copy link
Member

close #11697

Copy link

github-actions bot commented Aug 23, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 33.9 kB
vue.global.prod.js 159 kB 57.5 kB 51.1 kB

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.8 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Aug 23, 2024

commit: f1bc285

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11699

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11699

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11699

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11699

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11699

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11699

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11699

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11699

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11699

vue

pnpm add https://pkg.pr.new/vue@11699

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11699

Open in Stackblitz

@jh-leong
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Aug 23, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure failure
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@jh-leong jh-leong marked this pull request as draft August 24, 2024 08:06
@jh-leong jh-leong marked this pull request as ready for review August 24, 2024 08:46
@edison1105 edison1105 added scope: types ready for review This PR requires more reviews labels Aug 25, 2024
@yyx990803 yyx990803 merged commit fe07f70 into vuejs:main Sep 3, 2024
13 checks passed
@jh-leong jh-leong deleted the fix/11697 branch September 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR requires more reviews scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defineModel with get/set option report types error
4 participants