Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): handle kebab-case shorthand bindings in import usage check #11754

Closed
wants to merge 1 commit into from

Conversation

jh-leong
Copy link
Member

close #11745

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 33.9 kB
vue.global.prod.js 159 kB 57.5 kB 51.1 kB

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.8 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Aug 30, 2024

commit: 80bfbbe

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11754

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11754

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11754

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11754

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11754

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11754

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11754

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11754

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11754

vue

pnpm add https://pkg.pr.new/vue@11754

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11754

Open in Stackblitz

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: sfc 🐞 bug Something isn't working labels Aug 30, 2024
@yyx990803 yyx990803 closed this in 0f7c0e5 Sep 2, 2024
@yyx990803
Copy link
Member

Root cause is we forgot to convert to camelCase when collecting template usage for such case - see 0f7c0e5 (reused test from this PR)

@jh-leong jh-leong deleted the fix/11745 branch September 2, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready to merge The PR is ready to be merged. scope: sfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same-name Shorthand with imported const
3 participants